Extending test timeout on slow platforms #915
Conversation
Thank you for creating a pull request!Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work). Code Quality and Contributing GuidelinesIf you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before. TestsGithub actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation. In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post |
|
Fixes #852 |
|
Just a successful test run. Whether it prevents the issue or not, I want to be sure this hasn't broken anything. |
While you're waiting - any chance you can adjust the commit message to call out s390x and riscv64 explicitly - it can be really useful when searching commit messages in the future. |
These platforms can take over 10 hours to run a full suite of extended.openjdk tests, even when split between 3 parallel machines. Therefore we should extend the timeout to allow the tests to run to completion. Signed-off-by: Adam Farley <[email protected]>
adamfarley
force-pushed
the
extend_test_time_limit_on_riscv
branch
from
4e3b21e
to
2384ca8
Compare
Sure, done. |
|
@adamfarley Is that a manual test run or since hte GH Action Checks have passed we can merge this? |
It's a manual test run referred to in the issue here. Unfortunately the change does not appear to be working. I'm looking into it now. |
Signed-off-by: Adam Farley <[email protected]>
|
Ok, here's a rerun with some debug messages: https://ci.adoptium.net/job/build-scripts/job/jobs/job/jdk22/job/jdk22-linux-s390x-temurin/16/ And here's a rerun using the upstream pipeline job, in case this is one of those things that's outside the scope of the job parameters. https://ci.adoptium.net/job/build-scripts/job/openjdk22-pipeline/118/ |
This way we only override the test job's default time limit if we've set it explicitly. Signed-off-by: Adam Farley <[email protected]>
Signed-off-by: Adam Farley <[email protected]>
|
Ok, I've put in the fix for the TIME_LIMIT-not-being passed downstream issue, and I've refined the formatting. If this job passes the variable correctly, we're good to merge. https://ci.adoptium.net/job/build-scripts/job/jobs/job/jdk22/job/jdk22-linux-s390x-temurin/21/ |
Signed-off-by: Adam Farley <[email protected]>
|
Variable passes correctly. Good to go. Requesting a re-review as the code was changed significantly after the last reviews. |
adamfarley
changed the title
|
Noting that https://ci.adoptium.net/job/Test_openjdk22_hs_extended.openjdk_s390x_linux_testList_0/13/ took just over 20 hours on test-marist-ubuntu2204-s390x-1) (That job seems to have been run with |
|
Okie dokie, will make another PR. - #928 |
Some platforms can take over 10 hours to run a full suite of extended.openjdk tests, even when split between 3 parallel machines.
Therefore we should extend the timeout to allow the tests to run to completion.